Move CLP IR types from the ffi to the ir namespace. #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraymo
reviewed
Dec 29, 2023
There was a problem hiding this comment.
Why should we explicitly add ir:: for variables in some files, but for others we have using ir::?
There was a problem hiding this comment.
usingdeclarations are banned in header files.- In source files, we use
usingdeclarations when it reduces the amount of typing without reducing clarity.- Generally, this means if we use a symbol from a namespace multiple times in a source file, we are better off adding a
usingdeclaration for that symbol and not fully-qualifying it every time we use it in the source file. - However, in some cases, not fully-qualifying a symbol can reduce clarity.
- Generally, this means if we use a symbol from a namespace multiple times in a source file, we are better off adding a
wraymo
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When developing the FFI code, we created new types in the
ffinamespace instead of using the existing ones in CLP core. This was to avoid depending on types within CLP core which would require FFI libraries to pull in complicated CLP core source files.As part of restructuring CLP core to be more modular, this PR moves the types into the
irnamespace. In a future PR, we will remove any redundant types from CLP core (e.g.,epochtime_twill be replaced withepoch_time_ms_t).The PR also does some minor refactoring like removing a
usingdeclaration from a header file, alphabetizing files inCMakeLists.txt, etc.Validation performed